gen3: serve the amp Ideal page for every amp model - #86
Open
ptn wants to merge 1 commit into
Open
Conversation
The Amp block editor never showed its Ideal tab. Two thirds of amp
models were missing it entirely, and the ones that did have it got it
twice on model 0.
The editor gates amp pages on the selected model, and ends each group
of pages with a catch-all whose value list is blank — the page it shows
for every model the explicit entries don't name. We parsed that blank
list into [0] instead of into nothing, because Number('') is 0. So the
catch-all looked like a page for model 0: hidden from the other 330
models, and duplicated on the one it appeared to claim.
Blank entries are now dropped when parsing a selector value list, and a
page whose list ends up empty is treated as its group's default — used
only when no explicit page matches. Groups without a catch-all are
unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Amp block editor never showed its Ideal tab. Two thirds of amp
models were missing it entirely, and the ones that did have it got it
twice on model 0.
The editor gates amp pages on the selected model, and ends each group
of pages with a catch-all whose value list is blank — the page it shows
for every model the explicit entries don't name. We parsed that blank
list into [0] instead of into nothing, because Number('') is 0. So the
catch-all looked like a page for model 0: hidden from the other 330
models, and duplicated on the one it appeared to claim.
Blank entries are now dropped when parsing a selector value list, and a
page whose list ends up empty is treated as its group's default — used
only when no explicit page matches. Groups without a catch-all are
unaffected.