gen3: never let the walk reclassify a catalog-known param - #87
Open
ptn wants to merge 1 commit into
Open
Conversation
The on-connect self-describe walk's enum/float split is a numeric heuristic (integral bounds + step/scale shape gated on a label-list probe) and it is not reliable in either direction. On an FM3 fw13.0, DISTORT_INPUTSELECT (paramId 21) walks as 'float' while the byte-identical REVERB selector (paramId 47) walks as 'enum' on the same device/build, and CABINET_LOCUT1/2 (paramId 62/63) walk as 'enum' despite being continuous Hz knobs. The device-cache-over-static range merge let the walk's row win unconditionally, so the bad classification silently overwrote the good one — INPUTSELECT reached Axis as a bare numeric value instead of its LEFT/RIGHT/SUM L+R dropdown, and the Cabinet Low Cut knobs rendered as dropdowns. The static catalog's 'kind' is mined offline from the editor's own cache, so when the walk disagrees on a pid the static table already classifies, trust the static classification. The walk still wins everywhere else, including proving a NEW pid the static table lacks, and still refines a same-kind float's display range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The on-connect self-describe walk's enum/float split is a numeric heuristic
(integral bounds + step/scale shape gated on a label-list probe) and it is not
reliable in either direction. On an FM3 fw13.0, DISTORT_INPUTSELECT (paramId 21)
walks as 'float' while the byte-identical REVERB selector (paramId 47) walks as
'enum' on the same device/build, and CABINET_LOCUT1/2 (paramId 62/63) walk as
'enum' despite being continuous Hz knobs.
The device-cache-over-static range merge let the walk's row win unconditionally,
so the bad classification silently overwrote the good one — INPUTSELECT reached
Axis as a bare numeric value instead of its LEFT/RIGHT/SUM L+R dropdown, and the
Cabinet Low Cut knobs rendered as dropdowns.
The static catalog's 'kind' is mined offline from the editor's own cache, so when
the walk disagrees on a pid the static table already classifies, trust the static
classification. The walk still wins everywhere else, including proving a NEW pid
the static table lacks, and still refines a same-kind float's display range.