gen3: ignore stale device caches until rebuilt - #88
Open
ptn wants to merge 1 commit into
Open
Conversation
The walk-reclassification guard above cannot correct an already-built cache: a stale row that tagged a param the wrong kind keeps surfacing from the persisted device cache until it is rebuilt. Gate the on-connect cache lookup on the cache schema version, so caches written before the current schema are ignored and rebuilt on next connect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The walk-reclassification guard above cannot correct an already-built cache: a
stale row that tagged a param the wrong kind keeps surfacing from the persisted
device cache until it is rebuilt. Gate the on-connect cache lookup on the cache
schema version, so caches written before the current schema are ignored and
rebuilt on next connect.
Depends on forgefx-midi
fix/cabinet-lowcut-enum-walk(addsCACHE_SCHEMAtoforgefx-midi/cache); needs a forgefx-midi release before this can merge. CItracks forgefx-midi's default-branch HEAD, so checks pass as-is.