W-22550539: prevent command injection in DevOps checkout guidance#465
Open
jag-j wants to merge 1 commit into
Open
W-22550539: prevent command injection in DevOps checkout guidance#465jag-j wants to merge 1 commit into
jag-j wants to merge 1 commit into
Conversation
Fixes W-22550539 Addresses command injection vulnerability where branch names were embedded directly into shell command strings without validation or escaping in the checkout helper's "Agent execution guide". Changes: - Import and use validateGitBranchName() to validate branch names - Added shellEscape() function for safe shell argument escaping - All git commands now use shell-escaped branch names - Added 10 comprehensive security test cases - Tests validate rejection of POC from W-22550539 - Tests verify shell escaping in generated commands Security improvements: - Validates branch name format before use - Blocks command injection patterns (;, |, $(), backticks) - Blocks path traversal attempts (..) - Shell-escapes branch names with single quotes - Prevents arbitrary command execution in agent environments Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes @W-22550539@
Addresses command injection vulnerability where branch names were embedded directly into shell command strings without validation or escaping in the checkout helper's "Agent execution guide".
Changes:
Security improvements:
What does this PR do?
What issues does this PR fix or reference?