Slim CI Format job and unpin ocamlformat#4
Merged
Conversation
The Format job ran `opam install . --deps-only`, pulling in the project's library dependencies. But `dune build @fmt` only runs ocamlformat and diffs; it never compiles the project, so those libraries are unused there. Replace the deps install with an explicit `dune` + `ocamlformat` install. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Drop the `0.29.0` pin from both the CI formatter install and the `.ocamlformat` `version` field so formatting tracks the installed ocamlformat rather than a fixed release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trims the CI
Formatjob down to the tooling formatting actually needs, and removes theocamlformatversion pin.opam install . --deps-onlystep from theFormatjob.dune build @fmtonly runs ocamlformat and diffs the result — it never compiles the project, so the library dependencies (yojson, etc.) are unused there.ocaml/setup-ocaml@v3does not installdune, soduneis now installed explicitly alongside the formatter.0.29.0pin from both the formatter install and the.ocamlformatversionfield, so formatting tracks the installed ocamlformat rather than a fixed release.Changes
.github/workflows/ci.yml: collapsed theInstall dependencies+Install formattersteps into a singleInstall dune and ocamlformatstep (opam install dune ocamlformat)..ocamlformat: removed theversion = 0.29.0line.Verification
opam exec -- dune build @fmtpasses locally.testjob is left unchanged (building/running tests still needs the full deps).