Remove the Scribe.noop logger#6
Merged
Merged
Conversation
Keep the core Scribe library focused on the essential building blocks
of value-based structured logging. The noop logger was a convenience
value that users can assemble in a line when needed, e.g.
Scribe.create ~level:Scribe.Level.Debug
~sink:(Scribe.Sink.make (fun _ -> ()))
Drop the value and its test, and reword the module doc comment that
referenced it. The Scribe_sinks.Noop sink is unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the prebuilt
Scribe.nooplogger from the core library soScribeships only the essential building blocks of value-based structured logging (levels, fields, events, sinks, loggers).A noop logger is a convenience value users can assemble in a line when they actually need one, so it doesn't need to live in the core API:
Changes
lib/scribe.ml— delete thelet noop = …definition.lib/scribe.mli— removeval noop : tand its doc comment; reword the module-level doc comment that referenced[noop]so it no longer dangles.test/test_scribe.ml— deletetest_noopand its"noop logger"registration.The
Scribe_sinks.Noopsink is intentionally left unchanged — it's a concrete sink in the separatescribe.sinkspackage (not a logger), and it's exactly the primitive used to rebuild a noop logger. Its"noop sink"test stays.Verification
dune build @fmt— formatting passesdune build— compiles, no remainingScribe.noopreferencesdune runtest— 4/4 tests pass (includingnoop sink)dune build @install— passes