chore: remove requirements.txt to resolve dependency build error#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the codebase, focusing on enhanced validation, more robust error handling, and the addition of comprehensive tests. It also includes minor dependency and version updates. The most significant changes are grouped below.
Error Handling and Validation Improvements:
ValueErrorexceptions with customClientConfigErrorinTermiiClientfor missing API key or base URL, providing clearer error messages and guidance.Falsefor non-string inputs inis_valid_phone_number.send_messageandsend_bulk_messageto normalize and validate thechannelandtypeparameters, with clearer error messages for invalid combinations. [1] [2]Testing Enhancements:
test_client.py,test_http.py, andtest_value_object.pyto verify client configuration, HTTP request handling, and phone number validation, respectively. These tests cover both successful cases and error scenarios. [1] [2] [3]pyproject.tomlto includepytestas an optional dependency for testing.Code Quality and Maintenance:
RequestHandler.post_fileto use a context manager, ensuring files are properly closed after upload.0.1.0to0.1.2intermii_py/__init__.py.Cleanup:
TermiiClientinitializer after moving them earlier in the method.