drop unicode characters in source files#196
Merged
Merged
Conversation
Comments now spell out their spec references in ASCII ("sec.", "--",
"->"); string literals that must emit a glyph, such as the diff tree
connectors, use \u{XXXX} escapes so the output bytes are unchanged.
Keeps the tree 7-bit so the section sign and em dash cannot creep back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source stays 7-bit ASCII. Comments spell their spec references in ASCII ("sec.", "--", "->"); the few string literals that must emit a glyph, such as the diff tree connectors and the invalid-selector test inputs, use
\u{XXXX}escapes so the runtime bytes are unchanged. A pre-commit hook rejects a non-ASCII byte in staged OCaml source so it cannot creep back.