rule: parse arbitrary selector in not-[...] instead of escaping it#167
Merged
Conversation
not-[<selector>] treated any non-pseudo, non-media bracket content as a single class name, so not-[.os-macos_&]:block emitted :not(.\.os-macos_\&) instead of :not(.os-macos *). Parse the content as a selector, with _ as a space and & as the universal inside the negation, matching Tailwind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
not-[<selector>]variant treated any non-pseudo, non-media bracket content as a single class name, sonot-[.os-macos_&]:blockemitted:not(.\.os-macos_\&)instead of:not(.os-macos *)(andnot-[.foo]gave:not(.\.foo),not-[[open]]gave:not(.\[open\])).It now parses the bracket content as a selector, with
_as a space and&as the universal selector inside the negation, matching Tailwind. Invalid combinator-leading forms (not-[+img]) are still rejected upstream and emit nothing.