color: apply /opacity to ring colours on var-ref themes#169
Open
samoht wants to merge 1 commit into
Open
Conversation
hex_alpha_color returned None when the scheme binds a palette colour to a var reference rather than a concrete hex, so ring/inset-ring/ring-offset dropped the /opacity modifier and emitted the ring colour at full opacity. Convert through oklch in that case, matching color_with_opacity_style, so ring-blue-500/50 applies its alpha like bg/text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a theme that binds palette colours to var references (no concrete hex in the scheme),
ring-blue-500/50,inset-ring-*/N, andring-offset-*/Ndropped the/opacitymodifier and emitted--tw-ring-color: var(--color-blue-500)at full opacity, whilebg/text/borderapplied it.Color.hex_alpha_colornow converts the colour through oklch in that case (the same pathcolor_with_opacity_stylealready uses for bg/text/border), so the ring family applies the alpha. Colours the scheme resolves to a concrete hex are unaffected.