backgrounds: keep both axes in a keyword+length bg-position bracket#171
Merged
Conversation
parse_bracket_position accepted a two-axis value only when both axes were a length or percentage, so bg-position-[center_-100px] fell back to a bare "center", dropping the -100px. Parse each axis as a keyword edge (left/right/top/bottom/center, normalised to its percentage) or a length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A two-axis
bg-position-[…]value that mixed a keyword edge with a length (e.g.bg-position-[center_-100px]) fell back to a barecenter, silently dropping the length.parse_bracket_positionnow parses each axis as a keyword edge (left/right/top/bottom/center, normalised to its percentage) or a length, sobg-position-[center_-100px]emitsbackground-position: 50% -100px.