Skip to content

fix: review findings batch - wiki auth, pg_adapter allowlist, 003 migration, ingest txn, true SSE, docker/CI/docs - #25

Merged
sanjeevafk merged 5 commits into
mainfrom
fix/all-review-findings
Sep 4, 2026
Merged

fix: review findings batch - wiki auth, pg_adapter allowlist, 003 migration, ingest txn, true SSE, docker/CI/docs#25
sanjeevafk merged 5 commits into
mainfrom
fix/all-review-findings

Conversation

@sanjeevafk

Copy link
Copy Markdown
Owner

Batch fix for the project review findings (all items per agreed scope: wiki auth-only, API keys preserve+extend, true SSE, defer 70% coverage + rank-bm25 swap).

Security

  • Wiki lint/concepts routes now require auth (shared vault kept)
  • pg_adapter allowlists RPC functions/tables/columns
  • Removed pickle FilesystemRAGStore (RCE path, dead code)
  • API keys: constant-time compare + optional expires_at/scopes/revoked_at via 003 (old hashes still work)

Correctness

  • Fixed reinitialize_cache NameError; pyright single-sourced to pyrightconfig.json
  • New db/migrations/003_fixes.sql: UUID defaults, centered get_neighbor_chunks, cascading delete_collection, key columns (verified live against pgvector:pg17)
  • Ingest: chunk/embed/graph moved out of txn with pre-txn idempotency short-circuit; 403 on cross-tenant collection; ILIKE metachars escaped; bare excepts now log

Streaming

  • True token SSE via OpenAI stream + shared _retrieve helper (single LLM call), disconnect-aware

Ops/docs

  • Dockerfile: non-root USER, HEALTHCHECK, strips tests; Dockerfile.test fixed (async deps, both suites); .dockerignore covers .env*
  • New .github/workflows/ci.yml (ruff+pytest); README fixed (no demo/, key length aligned, docker contexts)
  • Eval: --seed, shrink warning, retired-baseline no longer raises; stale modular_services README corrected

Verification: 190/190 pytest pass, ruff + compileall + diff-check clean, 003 applied live (queue/neighbor/delete_collection exercised).

Excluded: pre-existing dirty scripts/benchmark_beir.py (unrelated BEIR multi-dataset WIP) left uncommitted.

@sanjeevafk
sanjeevafk merged commit 7e8c61b into main Sep 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant