Support updates to positions of scatter3d points#559
Open
Conversation
nvaytet
changed the title
nvaytet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #484
Much of the changes are similar, but things are written in a simpler manner here, and we do not check for equality of coordinates (as this took time).
Updating the positions is between 3 and 10 times faster than updating the colors.
The gain of removing the unexpected behaviour that positions don't update (only colors used to update) are worth the cost, I think.
I tried looking at the Dream instrument view again and the loss of performance was not noticeable, contrary to what I wrote in #484 (comment)
Possibly because of performance updates done on the instrument view side itself? (scipp/scippneutron#691)
Fixes #495