Skip to content

Fix visible check #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Serpentarius13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix visible check #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "stage-ui",
"author": "Script Heads",
"version": "0.7.34",
"version": "0.7.35",
"license": "MIT",
"private": true,
"workspaces": [
Expand Down
5 changes: 4 additions & 1 deletion packages/core/hooks/components/DropRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ export const DropRenderer = () => {
(e as CustomEvent<{ self: Node }>)?.detail?.self || (e as React.MouseEvent).target

if (visible) {
if (document.getElementById('drop-renderer')?.contains?.(target)) {
if (
target instanceof Node &&
document.getElementById('drop-renderer')?.contains?.(target)
) {
return
}
dropDelegate.close()
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@stage-ui/core",
"description": "Flexible UI components library declared by your own Design System.",
"version": "0.7.34",
"version": "0.7.35",
"license": "MIT",
"homepage": "https://stageui.shds.io/",
"bugs": "https://github.com/script-heads/stage-ui/issues",
Expand Down
2 changes: 1 addition & 1 deletion packages/icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@stage-ui/icons",
"description": "Flexible UI components library declared by your own Design System.",
"version": "0.7.34",
"version": "0.7.35",
"license": "MIT",
"homepage": "https://stageui.shds.io/",
"bugs": "https://github.com/script-heads/stage-ui/issues",
Expand Down
2 changes: 1 addition & 1 deletion packages/system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@stage-ui/system",
"description": "Flexible UI components library declared by your own Design System.",
"version": "0.7.34",
"version": "0.7.35",
"license": "MIT",
"homepage": "https://stageui.shds.io/",
"bugs": "https://github.com/script-heads/stage-ui/issues",
Expand Down