Skip to content

Make info gene test tolerate missing enrichment - #268

Open
daveringelberg wants to merge 1 commit into
scverse:devfrom
daveringelberg:fix/info-gene-flaky
Open

Make info gene test tolerate missing enrichment#268
daveringelberg wants to merge 1 commit into
scverse:devfrom
daveringelberg:fix/info-gene-flaky

Conversation

@daveringelberg

Copy link
Copy Markdown

Summary

  • make test_info_gene use a custom assertion for gget info DataFrame output
  • keep Ensembl-derived fields strict while allowing UniProt/NCBI best-effort columns to be absent when upstream enrichment is unavailable
  • still validate UniProt/NCBI enrichment values when they are returned

Fixes #267

Tests

  • python -m pytest tests/test_info.py -q
  • python -m ruff check tests/test_info.py
  • python -m ruff format --check tests/test_info.py

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.42%. Comparing base (e43a804) to head (127523d).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #268      +/-   ##
==========================================
+ Coverage   56.70%   57.42%   +0.71%     
==========================================
  Files          29       29              
  Lines        9392     9392              
==========================================
+ Hits         5326     5393      +67     
+ Misses       4066     3999      -67     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveringelberg
daveringelberg marked this pull request as draft July 29, 2026 23:23
@daveringelberg
daveringelberg marked this pull request as ready for review July 30, 2026 06:54
@daveringelberg

Copy link
Copy Markdown
Author

CI failures appear unrelated to this PR: test_info_gene passes on all Python versions, while the visible failures are in test_cellxgene.py::TestCellxgene::test_cellxgene_adata. Happy to rerun or adjust if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants