Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 91.09% 91.03% -0.06%
==========================================
Files 11 11
Lines 1819 1819
==========================================
- Hits 1657 1656 -1
- Misses 162 163 +1 🚀 New features to boost your workflow:
|
flying-sheep
commented
Jun 29, 2026
ilia-kats
requested changes
Jun 30, 2026
ilia-kats
left a comment
ilia-kats
left a comment
Collaborator
There was a problem hiding this comment.
Great, thanks! A few minor comments, looks good otherwise.
Co-authored-by: ilia-kats <ilia-kats@gmx.net>
ilia-kats
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the
ad.__version__and didn’t realize at the time that it’s already deprecated.Remembering that made me realize that we’re not testing for warnings here. This PR introduces that.