[pull] master from unlock-protocol:master - #149
Merged
Conversation
…16607) - loginWithPrivy: return after the wallet/token mismatch 401. The missing return created a session for the mismatched wallet and then crashed on a second send ("Cannot set headers after they are sent"). - loginWithPrivy: tolerate an unparsed body (Express 5 leaves request.body undefined when no parser matched), which surfaced as a misleading 401 "Invalid access token" instead of the 400 "Access token is required". - loginWithPrivy: log request diagnostics (origin, UA, content-type, content-length, body keys) on every rejection so the current wave of 400s on /v2/auth/privy can be attributed from Better Stack. - authMiddleware: the "Unsupported authorization type" branch referenced Express's `response` prototype, threw, and fell through to next(). Drop the broken import and make the fall-through explicit with a warning. Claude-Session: https://claude.ai/code/session_01Xyw4VrQMe4pkTe7aV6WEJd Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…-service (#16610) Both Cloudflare workers bundle @unlock-protocol/networks (provider also @unlock-protocol/contracts) from the packages' dist/ output, which the production workflow never built. Every production run since #16542 failed these two jobs with "Could not resolve @unlock-protocol/networks: The module ./dist/index.mjs was not found". wedlocks already used the pre-deploy-command input for the same purpose. Claude-Session: https://claude.ai/code/session_01Xyw4VrQMe4pkTe7aV6WEJd Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )