[pull] master from unlock-protocol:master - #151
Merged
Conversation
…16614) * fix(locksmith): redact credentials from HTTP request and error logs The express-winston request logger recorded req.headers and req.url verbatim, so every Authorization bearer (a live Locksmith session id), Cookie header and api-key query parameter ended up in the log stream — visible in Railway now that winston writes to stdout (#16612). Move the logger options to src/utils/requestLogger.ts and apply them to both the request and the error logger: blacklist the authorization and cookie headers, redact api-key in query/url/originalUrl, and build the message line from req.path instead of req.url. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xyw4VrQMe4pkTe7aV6WEJd * test(locksmith): terminate the error-logger test app explicitly The redaction test for the error logger relied on Express's default final handler to end the response and hung in CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xyw4VrQMe4pkTe7aV6WEJd --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )