Skip to content

Update HttpClient tests to use httpbingo.org instead of httpbin.seatsio.net#151

Merged
mroloux merged 1 commit into
masterfrom
matti/use-httpbingo
Jun 29, 2026
Merged

Update HttpClient tests to use httpbingo.org instead of httpbin.seatsio.net#151
mroloux merged 1 commit into
masterfrom
matti/use-httpbingo

Conversation

@mroloux

@mroloux mroloux commented Jun 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@mroloux mroloux requested a review from a team as a code owner June 29, 2026 10:44
@mroloux mroloux requested review from bverbeken, Copilot and schaloner and removed request for a team June 29, 2026 10:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the HttpClient integration-style tests to use the public httpbingo.org service instead of the previously seatsio-hosted httpbin.seatsio.net, keeping the tests’ expected exception messages in sync with the new base URL.

Changes:

  • Switched ExponentialBackoff tests to target https://httpbingo.org and updated asserted error messages accordingly.
  • Switched the timeout/error-handling test to target https://httpbingo.org and updated the asserted error message accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/testExponentialBackoff.py Repoints backoff/retry tests to httpbingo and updates expected URLs in exception messages.
tests/testErrorHandling.py Repoints timeout test to httpbingo and updates expected URL in exception message.
Comments suppressed due to low confidence (1)

tests/testExponentialBackoff.py:71

  • The last test uses a nonstandard /status/429:0.25,204:0.75 endpoint (weighted/random status codes). This looks specific to the previous seatsio-hosted httpbin instance and may not be supported by httpbingo.org, which would make this test fail or become flaky. Consider replacing this with a deterministic local stub server (first N requests => 429, then 204) or another httpbingo-supported endpoint that reliably returns a 429 followed by success.
        client = HttpClient("https://httpbingo.org", "aSecretKey", None, 5)

        i = 0
        while i < 20:
            client.url("/status/429:0.25,204:0.75").post()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mroloux mroloux merged commit f4b5e79 into master Jun 29, 2026
3 checks passed
@mroloux mroloux deleted the matti/use-httpbingo branch June 29, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants