Skip to content

feat(observability): OTel instrumentation + HTTP idle-pool options #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdchatham wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(observability): OTel instrumentation + HTTP idle-pool options #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d626589
refactor(sender): configurable HTTP idle-conn pool with defaults 500/50
bdchatham Apr 21, 2026
bb74d4d
sender: drop implicit worker-derived override, rely on 500/50 defaults
bdchatham Apr 21, 2026
1c9aae4
feat(observability): OTel instrumentation for platform deployments
bdchatham Apr 21, 2026
7ef439a
observability: enable OpenMetrics + fix shutdown order + trim cardina…
bdchatham Apr 21, 2026
c4ba0c6
observability: drop bespoke OnceValue wrappers for idiomatic OTel
bdchatham Apr 21, 2026
057330e
observability: bump otelhttp v0.54.0 -> v0.68.0
bdchatham Apr 21, 2026
ef14cd4
observability: trim comments, move invariants to README
bdchatham Apr 21, 2026
ca5b8ee
ci: bump Go to 1.25.1 + golangci-lint to v2.1.6
bdchatham Apr 21, 2026
2ba94e4
ci: golang:1.25.1-bookworm (bullseye variant not published for Go 1.25)
bdchatham Apr 21, 2026
0002e56
ci: golangci-lint-action @v7 (v6 doesn't support golangci-lint v2.x)
bdchatham Apr 21, 2026
0b22e5d
ci: golangci-lint version latest (v2.1.6 still built on Go 1.24)
bdchatham Apr 21, 2026
16d3027
lint: fix issues surfaced by golangci-lint v2
bdchatham Apr 21, 2026
95fe37c
review: address amir-deris feedback on PR #28
bdchatham Apr 22, 2026
86ea8b2
fix: hold /metrics open after EmitRunSummary so the gauges get scraped
bdchatham Apr 26, 2026
1429134
test: extend settings tests for PostSummaryFlushDelay
bdchatham Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
go-version: [1.24.5]
go-version: [1.25.1]
Comment thread
bdchatham marked this conversation as resolved.

steps:
- name: Checkout code
Expand Down Expand Up @@ -40,12 +40,9 @@ jobs:
run: go mod verify

- name: Install golangci-lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@v7
with:
version: latest
skip-cache: false
skip-pkg-cache: false
skip-build-cache: false

- name: Run linting
run: make lint
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.5-bullseye AS build
FROM golang:1.25.1-bookworm AS build

WORKDIR /go/src/sei-load

Expand Down
21 changes: 13 additions & 8 deletions config/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ type Settings struct {
RampUp bool `json:"rampUp,omitempty"`
ReportPath string `json:"reportPath,omitempty"`
TxsDir string `json:"txsDir,omitempty"`
TargetGas uint64 `json:"targetGas,omitempty"`
NumBlocksToWrite int `json:"numBlocksToWrite,omitempty"`
TargetGas uint64 `json:"targetGas,omitempty"`
NumBlocksToWrite int `json:"numBlocksToWrite,omitempty"`
PostSummaryFlushDelay Duration `json:"postSummaryFlushDelay,omitempty"`
}

// DefaultSettings returns the default configuration values
Expand All @@ -45,8 +46,9 @@ func DefaultSettings() Settings {
RampUp: false,
ReportPath: "",
TxsDir: "",
TargetGas: 10_000_000,
NumBlocksToWrite: 100,
TargetGas: 10_000_000,
NumBlocksToWrite: 100,
PostSummaryFlushDelay: Duration(25 * time.Second),
}
}

Expand All @@ -67,8 +69,9 @@ func InitializeViper(cmd *cobra.Command) error {
"rampUp": "ramp-up",
"reportPath": "report-path",
"txsDir": "txs-dir",
"targetGas": "target-gas",
"numBlocksToWrite": "num-blocks-to-write",
"targetGas": "target-gas",
"numBlocksToWrite": "num-blocks-to-write",
"postSummaryFlushDelay": "post-summary-flush-delay",
}

for viperKey, flagName := range flagBindings {
Expand All @@ -94,6 +97,7 @@ func InitializeViper(cmd *cobra.Command) error {
viper.SetDefault("txsDir", defaults.TxsDir)
viper.SetDefault("targetGas", defaults.TargetGas)
viper.SetDefault("numBlocksToWrite", defaults.NumBlocksToWrite)
viper.SetDefault("postSummaryFlushDelay", defaults.PostSummaryFlushDelay.ToDuration())
return nil
}

Expand Down Expand Up @@ -133,7 +137,8 @@ func ResolveSettings() Settings {
RampUp: viper.GetBool("rampUp"),
ReportPath: viper.GetString("reportPath"),
TxsDir: viper.GetString("txsDir"),
TargetGas: viper.GetUint64("targetGas"),
NumBlocksToWrite: viper.GetInt("numBlocksToWrite"),
TargetGas: viper.GetUint64("targetGas"),
NumBlocksToWrite: viper.GetInt("numBlocksToWrite"),
PostSummaryFlushDelay: Duration(viper.GetDuration("postSummaryFlushDelay")),
}
}
6 changes: 4 additions & 2 deletions config/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ func TestArgumentPrecedence(t *testing.T) {
cmd.Flags().String("txs-dir", "", "Txs dir")
cmd.Flags().Uint64("target-gas", 0, "Target gas")
cmd.Flags().Int("num-blocks-to-write", 0, "Number of blocks to write")
cmd.Flags().Duration("post-summary-flush-delay", 0, "Post-summary flush delay")

// Parse CLI args
if len(tt.cliArgs) > 0 {
Expand Down Expand Up @@ -137,8 +138,9 @@ func TestDefaultSettings(t *testing.T) {
RampUp: false,
ReportPath: "",
TxsDir: "",
TargetGas: 10_000_000,
NumBlocksToWrite: 100,
TargetGas: 10_000_000,
NumBlocksToWrite: 100,
PostSummaryFlushDelay: Duration(25 * time.Second),
}

if defaults != expected {
Expand Down
38 changes: 25 additions & 13 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/sei-protocol/sei-load

go 1.24.5
go 1.25.1

require (
github.com/ethereum/go-ethereum v1.16.1
Expand All @@ -9,21 +9,27 @@ require (
github.com/prometheus/client_golang v1.22.0
github.com/spf13/cobra v1.9.1
github.com/spf13/viper v1.20.1
github.com/stretchr/testify v1.10.0
go.opentelemetry.io/otel v1.37.0
github.com/stretchr/testify v1.11.1
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.68.0
go.opentelemetry.io/otel v1.43.0
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.43.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.43.0
go.opentelemetry.io/otel/exporters/prometheus v0.59.1
go.opentelemetry.io/otel/metric v1.37.0
go.opentelemetry.io/otel/sdk/metric v1.37.0
golang.org/x/sync v0.16.0
go.opentelemetry.io/otel/metric v1.43.0
go.opentelemetry.io/otel/sdk v1.43.0
go.opentelemetry.io/otel/sdk/metric v1.43.0
go.opentelemetry.io/otel/trace v1.43.0
golang.org/x/sync v0.20.0
golang.org/x/time v0.9.0
google.golang.org/protobuf v1.36.6
google.golang.org/protobuf v1.36.11
)

require (
github.com/Microsoft/go-winio v0.6.2 // indirect
github.com/StackExchange/wmi v1.2.1 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/bits-and-blooms/bitset v1.22.0 // indirect
github.com/cenkalti/backoff/v5 v5.0.3 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/consensys/gnark-crypto v0.18.0 // indirect
github.com/crate-crypto/go-eth-kzg v1.3.0 // indirect
Expand All @@ -33,6 +39,7 @@ require (
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
github.com/ethereum/c-kzg-4844/v2 v2.1.0 // indirect
github.com/ethereum/go-verkle v0.2.2 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fsnotify/fsnotify v1.8.0 // indirect
github.com/go-logr/logr v1.4.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
Expand All @@ -41,6 +48,7 @@ require (
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/websocket v1.4.2 // indirect
github.com/grafana/regexp v0.0.0-20240518133315-a468a5bfb3bc // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0 // indirect
github.com/holiman/uint256 v1.3.2 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
Expand All @@ -60,13 +68,17 @@ require (
github.com/supranational/blst v0.3.15 // indirect
github.com/tklauser/go-sysconf v0.3.12 // indirect
github.com/tklauser/numcpus v0.6.1 // indirect
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/otel/sdk v1.37.0 // indirect
go.opentelemetry.io/otel/trace v1.37.0 // indirect
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0 // indirect
go.opentelemetry.io/proto/otlp v1.10.0 // indirect
go.uber.org/atomic v1.9.0 // indirect
go.uber.org/multierr v1.9.0 // indirect
golang.org/x/crypto v0.40.0 // indirect
golang.org/x/sys v0.34.0 // indirect
golang.org/x/text v0.27.0 // indirect
golang.org/x/crypto v0.49.0 // indirect
golang.org/x/net v0.52.0 // indirect
golang.org/x/sys v0.42.0 // indirect
golang.org/x/text v0.35.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20260401024825-9d38bb4040a9 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260401024825-9d38bb4040a9 // indirect
google.golang.org/grpc v1.80.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
Loading
Loading