Skip to content

Increase Meilisearch's validation max_retries to 10 #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PierreMesure wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Increase Meilisearch's validation max_retries to 10 #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sequin/sinks/meilisearch/client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ defmodule Sequin.Sinks.Meilisearch.Client do
url: "/tasks/#{task_id}",
# We need to disable this if we use a custom retry that emits delays
retry_delay: nil,
max_retries: 5,
max_retries: 10,
retry: fn request, response_or_exception ->
should_retry =
case response_or_exception do
Expand Down
6 changes: 3 additions & 3 deletions test/sequin/meilisearch_client_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,12 +339,12 @@ defmodule Sequin.Sinks.Meilisearch.ClientTest do
assert error.details.task_id == 456
assert error.details.last_status == "processing"

# Verify we made all 6 attempts (1 initial + 5 retries)
for i <- 0..5 do
# Verify we made all 11 attempts (1 initial + 10 retries)
for i <- 0..10 do
assert_receive {:task_check, ^i}, 3_000
end

refute_receive {:task_check, 6}, 100
refute_receive {:task_check, 11}, 100
end

test "wait_for_task handles task failure" do
Expand Down
Loading