Skip to content

Migrate to .NET 8 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfitz42 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Migrate to .NET 8 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4eaf4c7
Migrate to .NET 8
sfitz42 May 16, 2025
d22553d
Update action runner
sfitz42 May 16, 2025
afaadcb
Update test dependencies
sfitz42 May 16, 2025
2fa6a22
Add .editorconfig
sfitz42 May 16, 2025
9b3d4dc
Inject CPU and Memory to test suite
sfitz42 May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
368 changes: 368 additions & 0 deletions .editorconfig
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 11 additions & 4 deletions .github/workflows/dotnet-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,24 @@ on:
jobs:
build:

runs-on: ubuntu-20.04
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Install .NET 6 SDK

- name: Install .NET 8 SDK
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x

- name: Restore projects
run: dotnet restore

- name: Check formatting
run: dotnet format --verify-no-changes

- name: Build projects
run: dotnet build --no-restore

- name: Run tests
run: dotnet test --no-build --verbosity normal
run: dotnet test --no-build --verbosity normal
344 changes: 171 additions & 173 deletions Intel8080.Emulator.Tests/FlagTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,174 +1,172 @@
using Intel8080.Emulator;
using Xunit;

namespace Intel8080.Emulator.Tests
{
public class FlagTests
{
private Flags _flags;

public FlagTests()
{
_flags = new Flags();

_flags.Clear();
}

[Fact]
public void SignBitIsSet_SetSignFlagTrue()
{
// Act
_flags.CalcSignFlag(0x8C);

// Assert
Assert.True(_flags.Sign);
Assert.Equal(0x82, _flags.F);
}

[Fact]
public void SignBitIsUnset_SetSignFlagFalse()
{
// Act
_flags.CalcSignFlag(0x7F);

// Assert
Assert.False(_flags.Sign);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Data_Zero_SetZeroFlagTrue()
{
// Act
_flags.CalcZeroFlag(0x00);

// Assert
Assert.True(_flags.Zero);
Assert.Equal(0x42, _flags.F);
}

[Fact]
public void Data_NonZero_SetZeroFlagFalse()
{
// Act
_flags.CalcZeroFlag(0x01);

// Assert
Assert.False(_flags.Zero);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void AuxiliaryCarry_ValueGreaterThan0x0F_SetAuxCarryFlagTrue()
{
// Act
_flags.CalcAuxCarryFlag(0x0F, 1);

// Assert
Assert.True(_flags.AuxiliaryCarry);
Assert.Equal(0x12, _flags.F);
}

[Fact]
public void AuxiliaryCarry_ValueLessThan0x0F_SetAuxCarryFlagFalse()
{
// Act
_flags.CalcAuxCarryFlag(0x00, 1);

// Assert
Assert.False(_flags.AuxiliaryCarry);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Parity_Even_SetParityFlagTrue()
{
// Act
_flags.CalcParityFlag(0x3F);

// Assert
Assert.True(_flags.Parity);
Assert.Equal(0x06, _flags.F);
}

[Fact]
public void Parity_Zero_SetParityFlagTrue()
{
// Act
_flags.CalcParityFlag(0x3F);

// Assert
Assert.True(_flags.Parity);
Assert.Equal(0x06, _flags.F);
}

[Fact]
public void Parity_Odd_SetParityFlagFalse()
{
// Act
_flags.CalcSignFlag(0x7F);

// Assert
Assert.False(_flags.Parity);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Carry_ValueGreaterThan0xFF_SetCarryFlagTrue()
{
// Act
_flags.CalcCarryFlag(0x0100);

// Assert
Assert.True(_flags.Carry);
Assert.Equal(0x03, _flags.F);
}

[Fact]
public void Carry_ValueEqual0xFF_SetCarryFlagFalse()
{
// Act
_flags.CalcCarryFlag(0xFF);

// Assert
Assert.False(_flags.Carry);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Carry_ValueGreaterThan0xFFFF_SetCarryFlagTrue()
{
// Act
_flags.CalcCarryFlagRegisterPair(0x010000);

// Assert
Assert.True(_flags.Carry);
Assert.Equal(0x03, _flags.F);
}

[Fact]
public void Carry_ValueLessThan0xFFFF_SetCarryFlagFalse()
{
// Act
_flags.CalcCarryFlagRegisterPair(0xFFFF);

// Assert
Assert.False(_flags.Carry);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Flags_Clear_SetFlagRegisterDefault()
{
// Arrange
_flags.CalcSignFlag(0xC0);
_flags.CalcParityFlag(0x80);

// Act
_flags.Clear();

// Assert
Assert.Equal(0x02, _flags.F);
}
}
using Xunit;

namespace Intel8080.Emulator.Tests;

public class FlagTests
{
private readonly Flags _flags;

public FlagTests()
{
_flags = new Flags();

_flags.Clear();
}

[Fact]
public void SignBitIsSet_SetSignFlagTrue()
{
// Act
_flags.CalcSignFlag(0x8C);

// Assert
Assert.True(_flags.Sign);
Assert.Equal(0x82, _flags.F);
}

[Fact]
public void SignBitIsUnset_SetSignFlagFalse()
{
// Act
_flags.CalcSignFlag(0x7F);

// Assert
Assert.False(_flags.Sign);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Data_Zero_SetZeroFlagTrue()
{
// Act
_flags.CalcZeroFlag(0x00);

// Assert
Assert.True(_flags.Zero);
Assert.Equal(0x42, _flags.F);
}

[Fact]
public void Data_NonZero_SetZeroFlagFalse()
{
// Act
_flags.CalcZeroFlag(0x01);

// Assert
Assert.False(_flags.Zero);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void AuxiliaryCarry_ValueGreaterThan0x0F_SetAuxCarryFlagTrue()
{
// Act
_flags.CalcAuxCarryFlag(0x0F, 1);

// Assert
Assert.True(_flags.AuxiliaryCarry);
Assert.Equal(0x12, _flags.F);
}

[Fact]
public void AuxiliaryCarry_ValueLessThan0x0F_SetAuxCarryFlagFalse()
{
// Act
_flags.CalcAuxCarryFlag(0x00, 1);

// Assert
Assert.False(_flags.AuxiliaryCarry);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Parity_Even_SetParityFlagTrue()
{
// Act
_flags.CalcParityFlag(0x3F);

// Assert
Assert.True(_flags.Parity);
Assert.Equal(0x06, _flags.F);
}

[Fact]
public void Parity_Zero_SetParityFlagTrue()
{
// Act
_flags.CalcParityFlag(0x3F);

// Assert
Assert.True(_flags.Parity);
Assert.Equal(0x06, _flags.F);
}

[Fact]
public void Parity_Odd_SetParityFlagFalse()
{
// Act
_flags.CalcSignFlag(0x7F);

// Assert
Assert.False(_flags.Parity);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Carry_ValueGreaterThan0xFF_SetCarryFlagTrue()
{
// Act
_flags.CalcCarryFlag(0x0100);

// Assert
Assert.True(_flags.Carry);
Assert.Equal(0x03, _flags.F);
}

[Fact]
public void Carry_ValueEqual0xFF_SetCarryFlagFalse()
{
// Act
_flags.CalcCarryFlag(0xFF);

// Assert
Assert.False(_flags.Carry);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Carry_ValueGreaterThan0xFFFF_SetCarryFlagTrue()
{
// Act
_flags.CalcCarryFlagRegisterPair(0x010000);

// Assert
Assert.True(_flags.Carry);
Assert.Equal(0x03, _flags.F);
}

[Fact]
public void Carry_ValueLessThan0xFFFF_SetCarryFlagFalse()
{
// Act
_flags.CalcCarryFlagRegisterPair(0xFFFF);

// Assert
Assert.False(_flags.Carry);
Assert.Equal(0x02, _flags.F);
}

[Fact]
public void Flags_Clear_SetFlagRegisterDefault()
{
// Arrange
_flags.CalcSignFlag(0xC0);
_flags.CalcParityFlag(0x80);

// Act
_flags.Clear();

// Assert
Assert.Equal(0x02, _flags.F);
}
}
Loading