Pin client TLS certificate#332
Open
TurboTheTurtle wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cert/certRawusable as a pinned peer certificate chainWhy
In client TLS mode, the provided certificate was only passed as an authority certificate. That is platform-dependent and does not handle the common case where users provide the server certificate itself rather than a CA. V2Ray already supports fail-closed peer certificate-chain pinning, so this maps
cert/certRawto that mechanism.Closes #330
Validation
/opt/homebrew/bin/gofmt -w main.go main_test.go/opt/homebrew/bin/go test ./.../opt/homebrew/bin/go build ./...git diff --checkPlease preserve author attribution if this PR is squashed or reworked:
Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>