Skip to content

Fix failing macos tests#4545

Merged
CloseChoice merged 4 commits into
shap:move-to-nanobindfrom
daidahao:fix-macos-tests
Apr 14, 2026
Merged

Fix failing macos tests#4545
CloseChoice merged 4 commits into
shap:move-to-nanobindfrom
daidahao:fix-macos-tests

Conversation

@daidahao

@daidahao daidahao commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Co-authored-by: Zhihao Dai zhihao.dai@eng.ox.ac.uk

Overview

Closes #4075, closes #3709

Add-on to #4366

The fix for OpenMP conflicts is taken from: unit8co/darts#3050 (comment). Credits to @dennisbader 🚀

Description of the changes proposed in this pull request:

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>
Co-authored-by: Zhihao Dai <zhihao.dai@eng.ox.ac.uk>

@CloseChoice CloseChoice left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CloseChoice CloseChoice merged commit 360a62e into shap:move-to-nanobind Apr 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants