Uppercase MATRIX_NAME env var in skaffold repo step - #403
Conversation
GitHub Actions step env vars are conventionally uppercase; align the inlined repo step with that convention. Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Change-Id: Idf50e666a4bfb4c7c23090e3a5953ef46a6a6964
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe profile-specific repository step now exports the matrix profile as ChangesProfile repository selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only standardizes the step environment variable name and its read site, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What
The repo step in
modules/devenv/integrations/github/skaffold.nixsets a stepenv var consumed inside the bash body. GitHub Actions step env keys are
conventionally uppercase, so rename it to
MATRIX_NAMEfor consistency withthe rest of the workflow's output names.
env.matrix_name→env.MATRIX_NAME''${MATRIX_NAME:-$name}Why
Aligns the inlined repo step with GitHub Actions naming conventions; no
behavioral change beyond the env key casing.
Related: #402
Summary by CodeRabbit