Skip to content

chore: finalize Clear Skies demo prep, fix CI, and establish CODEOWNERS#31

Merged
AbhishekDoshi26 merged 2 commits into
mainfrom
feat/shorebird_weather
Jul 10, 2026
Merged

chore: finalize Clear Skies demo prep, fix CI, and establish CODEOWNERS#31
AbhishekDoshi26 merged 2 commits into
mainfrom
feat/shorebird_weather

Conversation

@AbhishekDoshi26

Copy link
Copy Markdown
Member

Description

This PR finalizes the preparation for the Clear Skies Shorebird FlutterCon live demo. It introduces a streamlined presenter workflow, integrates the sample into our CI pipeline, and sets up repository-wide PR reviewer defaults.

✨ Key Changes

  • Streamlined Live Demo Workflow:
    • Refactored the intentional bugs in app_colors.dart, app_strings.dart, and welcome_hero_widget.dart. Instead of forcing the presenter to manually rewrite code on stage, the files now contain clearly marked // -- BUG VERSION -- and // -- CORRECT VERSION -- blocks. The presenter simply comments/uncomments the blocks.
  • FlutterCon Demo Guide:
    • Added clear_skies/FLUTTERCON_DEMO.md to serve as the definitive playbook for anyone presenting the demo. It includes setup instructions, the presentation script, and a specific guide for resetting the app for continuous booth demo loops.
  • CI Integration:
    • Registered the clear_skies project in .github/workflows/shorebird_ci.yaml. shorebird_ci verify now correctly identifies and builds the project on every PR.
  • Test Suite Fixes:
    • Fixed a failing unit test in weather_helper_test.dart that was asserting an outdated fog emoji. (All 70 tests are now passing).
  • CODEOWNERS Setup:
    • Added a .github/CODEOWNERS file at the root level to designate @AbhishekDoshi26 as the default reviewer, ensuring all future PRs across the repository are automatically assigned to the maintainer.

🧪 Verification

  • shorebird_ci verify runs successfully and no longer reports clear_skies as MISSING.
  • flutter test executes with 100% pass rate locally.

@AbhishekDoshi26 AbhishekDoshi26 force-pushed the feat/shorebird_weather branch from de6e2f5 to 00bbe4b Compare July 10, 2026 06:15
@AbhishekDoshi26 AbhishekDoshi26 enabled auto-merge (squash) July 10, 2026 06:22
@AbhishekDoshi26 AbhishekDoshi26 merged commit 19aba34 into main Jul 10, 2026
12 checks passed
@AbhishekDoshi26 AbhishekDoshi26 deleted the feat/shorebird_weather branch July 10, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants