Skip to content

6.3.1#278

Merged
shub39 merged 4 commits into
masterfrom
dev
Jun 4, 2026
Merged

6.3.1#278
shub39 merged 4 commits into
masterfrom
dev

Conversation

@shub39

@shub39 shub39 commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

Release 6.3.1

  • Bug Fixes
    • Fixed crashes in the Synced Lyrics page
  • Localization
    • Added 12 new Arabic language translations to improve app accessibility

ameen272 and others added 4 commits June 2, 2026 13:02
Currently translated at 100.0% (119 of 119 strings)

Translation: Rush/strings
Translate-URL: https://hosted.weblate.org/projects/rush/strings/en/
Currently translated at 94.1% (112 of 119 strings)

Translation: Rush/strings
Translate-URL: https://hosted.weblate.org/projects/rush/strings/ar/

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf152c5d-d5b5-4ac3-b13f-f400507e2f14

📥 Commits

Reviewing files that changed from the base of the PR and between ab76954 and 1a84e8c.

📒 Files selected for processing (10)
  • CHANGELOG.md
  • androidApp/build.gradle.kts
  • shared/logic/src/commonMain/composeResources/files/changelog.json
  • shared/ui/src/androidMain/kotlin/com/shub39/rush/shared/ui/setting/component/LocalePickerSheet.android.kt
  • shared/ui/src/commonMain/composeResources/values-ar/strings.xml
  • shared/ui/src/commonMain/composeResources/values/strings.xml
  • shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/component/ChangelogSheet.kt
  • shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/LineSyncedLyrics.kt
  • shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/LrcCorrectDialog.kt
  • shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/SyllableSyncedLyrics.kt

📝 Walkthrough

Walkthrough

Patch release 6.3.1 fixes crashes in the Synced Lyrics page by stabilizing Compose list item keys across multiple UI components. Version metadata, changelog records, and localization strings are updated to support the release. All keying changes add index-based composite keys to prevent recomposition identity conflicts.

Changes

Release 6.3.1 and Compose Stability Fixes

Layer / File(s) Summary
Version bump and changelog metadata
CHANGELOG.md, androidApp/build.gradle.kts, shared/logic/src/commonMain/composeResources/files/changelog.json
Version name and code incremented to 6.3.1/6310. Changelog entries in both markdown and JSON document the fix for crashes in the Synced Lyrics page.
Localization and string resource setup
shared/ui/src/commonMain/composeResources/values/strings.xml, shared/ui/src/commonMain/composeResources/values-ar/strings.xml
XML declaration added to default strings file. Twelve new Arabic string keys added for donation descriptions, synced lyrics modes (line_synced_lyrics, syllable_synced_lyrics), changelog UI, appearance section titles, app branding toggle, full-screen sharing, and romanization.
Compose list item key stability fixes
shared/ui/src/androidMain/kotlin/com/shub39/rush/shared/ui/setting/component/LocalePickerSheet.android.kt, shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/component/ChangelogSheet.kt, shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/LineSyncedLyrics.kt, shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/LrcCorrectDialog.kt, shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/SyllableSyncedLyrics.kt
Five UI components update their Compose itemsIndexed/itemKey lambdas to use composite keys combining index with value identifiers (index_name, index_time, index_startTime), replacing single-value keys that caused list recomposition crashes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • shub39/Rush#156: Both PRs modify Arabic localization string resources, adding Pro/donation/translation/synced-lyrics-related labels to the values-ar UI text.
  • shub39/Rush#244: Both PRs adjust Compose list item keying behavior in LineSyncedLyrics and synced lyrics rendering to improve list identity stability and prevent recomposition crashes.
  • shub39/Rush#234: Both PRs add/update the same UI string resource keys for synced lyrics modes (line_synced_lyrics, syllable_synced_lyrics) and changelog across different locales.

Poem

🐰 A crash in the lyrics, oh what a plight!
But composite keys bring Compose back to light.
With index and value, each item shines bright,
The Synced Lyrics page now renders just right! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title '6.3.1' is vague and generic, using only a version number without describing the actual changes made in the pull request. Use a descriptive title that summarizes the main change, such as 'Fix crashes in Synced Lyrics page' or 'Release version 6.3.1 with Synced Lyrics fixes'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shub39 shub39 merged commit cb1e030 into master Jun 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants