Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis 6.4.0 release adds a user-configurable auto-hide for lyrics controls, wires the preference through datastore and the view model, refactors enum qualification and album-art shape helpers, centralizes Kotlin compiler flags, and updates version and changelog artifacts. ChangesHide UI Control Feature
Enum Constant Unqualification and Shape Extension Rename
Version and Release Documentation
Build Configuration Consolidation
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
shared/ui/build.gradle.kts (1)
28-34:⚠️ Potential issue | 🟠 Major | ⚡ Quick winIncomplete migration: per-target task configuration should be removed.
Unlike
shared/coreandshared/logic, this module still retains the per-target task-level configuration for-Xexpect-actual-classes. According to the PR objective to centralize compiler options, this block should be removed and-Xexpect-actual-classesshould be moved into the centralizedcompilerOptionsblock (lines 36-43) alongside-Xcontext-sensitive-resolution.♻️ Proposed fix to complete the centralization
Remove this per-target configuration block:
- targets.all { - compilations.all { - compileTaskProvider.configure { - compilerOptions.freeCompilerArgs.add("-Xexpect-actual-classes") - } - } - } -And add
-Xexpect-actual-classesto the centralizedcompilerOptionsblock:compilerOptions { + freeCompilerArgs.add("-Xexpect-actual-classes") freeCompilerArgs.add("-Xcontext-sensitive-resolution") optIn.add("androidx.compose.material3.ExperimentalMaterial3Api")🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shared/ui/build.gradle.kts` around lines 28 - 34, Remove the per-target compile task configuration block that calls targets.all { compilations.all { compileTaskProvider.configure { compilerOptions.freeCompilerArgs.add("-Xexpect-actual-classes") } } } and instead add the "-Xexpect-actual-classes" entry to the centralized compilerOptions.freeCompilerArgs block (the existing shared compilerOptions block where "-Xcontext-sensitive-resolution" is set) so the flag is configured once centrally rather than per-target.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@shared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/LyricsPageState.kt`:
- Line 48: LyricsPageState defines hideUI with a default of true but the
datastore default in LyricsPagePreferencesImpl is false, causing a mismatch on
first launch; update the default in the LyricsPageState data class (the hideUI
property) to false so it matches the datastore default (or alternatively change
the datastore default to true if you prefer UI-first behavior) and ensure any
constructors or usages that rely on the old default are updated accordingly.
---
Outside diff comments:
In `@shared/ui/build.gradle.kts`:
- Around line 28-34: Remove the per-target compile task configuration block that
calls targets.all { compilations.all { compileTaskProvider.configure {
compilerOptions.freeCompilerArgs.add("-Xexpect-actual-classes") } } } and
instead add the "-Xexpect-actual-classes" entry to the centralized
compilerOptions.freeCompilerArgs block (the existing shared compilerOptions
block where "-Xcontext-sensitive-resolution" is set) so the flag is configured
once centrally rather than per-target.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4620a996-2fe7-4beb-b18a-7ffe02bdd3e5
📒 Files selected for processing (22)
CHANGELOG.mdandroidApp/build.gradle.ktsdesktopApp/src/commonMain/kotlin/com/shub39/rush/Main.ktshared/core/build.gradle.ktsshared/core/src/commonMain/kotlin/com/shub39/rush/shared/core/interfaces/LyricsPagePreferences.ktshared/logic/build.gradle.ktsshared/logic/src/commonMain/composeResources/files/changelog.jsonshared/logic/src/commonMain/kotlin/com/shub39/rush/shared/logic/datastore/LyricsPagePreferencesImpl.ktshared/ui/build.gradle.ktsshared/ui/src/commonMain/composeResources/values/strings.xmlshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/EnumExt.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/LyricsPageAction.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/LyricsPageState.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/Util.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/customisation/LyricsCustomisationSettings.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/lyrics/section/LyricsPage.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/share/SharePage.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/share/component/SharePageSheet.ktshared/ui/src/commonMain/kotlin/com/shub39/rush/shared/ui/viewmodels/LyricsVM.ktshared/ui/src/jvmMain/kotlin/com/shub39/rush/shared/ui/EnumExt.jvm.ktshared/ui/src/jvmMain/kotlin/com/shub39/rush/shared/ui/lyrics/component/customisation/LyricsCustomisationSettings.jvm.ktshared/ui/src/jvmMain/kotlin/com/shub39/rush/shared/ui/setting/section/SettingRootPage.jvm.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Other