Fix touch mapping on panels that advertise bogus display modes - #24
Open
jboetticher wants to merge 1 commit into
Open
Fix touch mapping on panels that advertise bogus display modes#24jboetticher wants to merge 1 commit into
jboetticher wants to merge 1 commit into
Conversation
convertGlassPointToContentPoint derived the touch glass aspect from largestModePixelSizeForDisplayID, which on generic USB touch panels (e.g. a WCH controller advertising a 540x1920 mode) is not the real panel geometry. The aspect mismatch letterbox-stretched one axis, placing taps far from the finger. A non-mirrored panel is its own display and the desktop fills the glass 1:1, so return the point unchanged unless it mirrors a differently-shaped master. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertGlassPointToContentPoint derived the touch glass aspect from largestModePixelSizeForDisplayID, which on generic USB touch panels (e.g. a WCH controller advertising a 540x1920 mode) is not the real panel geometry. The aspect mismatch letterbox-stretched one axis, placing taps far from the finger. A non-mirrored panel is its own display and the desktop fills the glass 1:1, so return the point unchanged unless it mirrors a differently-shaped master.
Dude i don't know it didn't work and then claude fixed it. not gonna pretend i understand