Skip to content

make Lock operations retriable#314

Open
phanky1 wants to merge 1 commit into
sibson:mainfrom
phanky1:retry-lock-operations
Open

make Lock operations retriable#314
phanky1 wants to merge 1 commit into
sibson:mainfrom
phanky1:retry-lock-operations

Conversation

@phanky1

@phanky1 phanky1 commented Apr 27, 2026

Copy link
Copy Markdown

Right now, the retry_period config doesn't apply to the self.lock object so if the Redis connection breaks right before tick() runs, self.lock.extend() throws an exception and beat stops.

This PR makes lock operations retriable when retry_period is set.

@sibson

sibson commented Apr 27, 2026

Copy link
Copy Markdown
Owner

Is there a reason the getattr() isn't properly wrapping lock() to be retry-able?

@phanky1
phanky1 force-pushed the retry-lock-operations branch from 2aff0f5 to 794b3d6 Compare April 28, 2026 03:05
@phanky1

phanky1 commented Apr 28, 2026

Copy link
Copy Markdown
Author

Is there a reason the getattr() isn't properly wrapping lock() to be retry-able?

it's because getattr() only wraps first-level method calls on the RetryingConnection. The returned objects of these method calls aren't bound to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants