Skip to content

Update to libpalaso 18 and L10NSharp 10#368

Open
Copilot wants to merge 2 commits intomasterfrom
copilot/update-to-libpalaso-18
Open

Update to libpalaso 18 and L10NSharp 10#368
Copilot wants to merge 2 commits intomasterfrom
copilot/update-to-libpalaso-18

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 27, 2026

  • Restore original "from" versions in CHANGELOG dependency update entries so they reflect cumulative changes since the last release (v5.1.0), not just the intermediate bump done in the previous PR

This change is Reviewable

Agent-Logs-Url: https://github.com/sillsdev/chorus/sessions/6635a3c5-c8dd-45c7-acc2-6412ca66d96d

Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
Copy link
Copy Markdown

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).


CHANGELOG.md lines 31-35 at r1 (raw file):

- Update libPalaso dependency from version 17.0.0-* to 18.0.0-*
- Update Newtonsoft.Json dependency from version 13.0.3 to 13.0.4
- Update Microsoft.NET.Test.Sdk dependency from version 17.3.1 to 17.14.1
- Update icu.net dependency from version 3.0.0-* to 3.0.1
- Update L10NSharp dependency from version 9.0.0-* to 10.0.0-*

Shouldn't the new CHANGLOG lines just update the "to" version and leave the "from" alone (as they reflect the cumulative change of the next release)?

- Update libPalaso dependency from version 15.0.0-* to 18.0.0-*
- Update Newtonsoft.Json dependency from version 13.0.2 to 13.0.4
- Update Microsoft.NET.Test.Sdk dependency from version 17.3.1 to 17.14.1
- Update icu.net dependency from version 3.0.0-* to 3.0.1
- Update L10NSharp dependency from version 8.0.0-beta0005 to 10.0.0-*

…t release

Agent-Logs-Url: https://github.com/sillsdev/chorus/sessions/85cfbf16-a70c-4492-9920-e362faf3c73f

Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
Copy link
Copy Markdown

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@imnasnainaec reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).

@jasonleenaylor jasonleenaylor enabled auto-merge (rebase) May 1, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants