Skip to content

Fix LT-21889: Add Find and Fix step for removing disowned children#372

Open
jtmaxwell3 wants to merge 1 commit intomasterfrom
LT-21889
Open

Fix LT-21889: Add Find and Fix step for removing disowned children#372
jtmaxwell3 wants to merge 1 commit intomasterfrom
LT-21889

Conversation

@jtmaxwell3
Copy link
Copy Markdown
Contributor

@jtmaxwell3 jtmaxwell3 commented May 1, 2026

This fixes https://jira.sil.org/browse/LT-21889. If the owner and stored owner don't match and the owner exists and the stored owner doesn't exist then the node has been disowned. This revealed some problems with the unit tests (type="o" instead of t="o").


This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

LCM Tests

    16 files  ±0      16 suites  ±0   3m 5s ⏱️ +5s
 2 858 tests ±0   2 838 ✅ ±0   20 💤 ±0  0 ❌ ±0 
11 380 runs  ±0  11 212 ✅ ±0  168 💤 ±0  0 ❌ ±0 

Results for commit f355c09. ± Comparison against base commit c459605.

@jasonleenaylor
Copy link
Copy Markdown
Contributor

tests/SIL.LCModel.FixData.Tests/FwDataFixerTests.cs line 484 at r1 (raw file):

			Assert.That(_errors[8], Is.EqualTo("Removing dangling link to Form '" + danglingMsaGuid + "' for WfiMorphBundle '" + danglingMorphNoRepairGuid + "'."),
				"Error message is incorrect."); // MorphBundleFixer--ksRemovingDanglingMorph
			Assert.True(_errors[9].StartsWith("Removing disowned object (invalid ownerguid='" + disownedOwnerGuid),

The added assert for the error message is good, but we should also have a new assert for the actual data being removed. I expected to see an assert below in the // Check file repair section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants