Skip to content

Follow up: audit hardening and CI - #14

Merged
silverbrit merged 6 commits into
feature/12.1-modernizationfrom
feat/12.1-audit-followups
Aug 18, 2026
Merged

Follow up: audit hardening and CI#14
silverbrit merged 6 commits into
feature/12.1-modernizationfrom
feat/12.1-audit-followups

Conversation

@silverbrit

@silverbrit silverbrit commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up work on top of feature/12.1-modernization. This adds the pending settings/package cleanup plus targeted audit fixes for custom aura trackers, anchors, Edit Mode, CI, native Better Tracked Bars settings integration, trinket defaults, and addon branding.

Settings and package refresh

  • Added a persistent settings-window opacity control, retaining the 0.72 default while allowing a fully opaque window.
  • Added a sidebar Changelog page with the single dated 33 (August 18 2026) release notes and updated the settings-window layout/navigation documentation.
  • Simplified the in-game release notes to medium-detail technical summaries and added the Unhalted development credit and Discord feedback note.
  • Added the missing PowerBar anchor-parent catalog and explicit UIParent (NONE) choices for bar positioning.
  • Kept restricted Power Bar values in Blizzard's FontString formatting path instead of clearing them from Lua.
  • Replaced the library XML aggregator with direct TOC library entries.
  • Removed unused packaged media assets and updated install-deps.sh for the new dependency layout.
  • Refreshed the README, CHANGELOG, and Options documentation to match the current addon architecture.

Custom tracker and anchor hardening

  • Separated spell cooldown availability from aura-candidate availability. A valid spell ID that is not in the spellbook can now render through CustomAuraContainerTemplate without querying cooldown state as if it were a learned spell.
  • Added regression coverage for aura-only spell metadata and unavailable non-aura sources.
  • Added CanBeAccessedInContext() validation to shared imported-anchor checks.
  • Routed Trinket Bar positioning through the shared safe anchor setter so forbidden, inaccessible, or throwing anchors fall back cleanly to UIParent.
  • Added inaccessible-anchor regression coverage.
  • Replaced the Edit Mode layout index's hardcoded preset offset with Blizzard's current preset-layout count, retaining a safe fallback.
  • Shared Better Tracked Bars settings embedding between the standalone /bcdm window and native AddOns Settings, detaching the external canvas cleanly when either panel closes.

Trinket defaults and migrations

  • Default the trinket viewer to show all equipped trinkets.
  • Center the default trinket bar on Blizzard's UIParent, while retaining the ElvUI player-frame anchor when ElvUI is active.
  • Migrate legacy ElvUI-anchored defaults idempotently and restore the contextual default on profile reset.

Addon metadata and minimap launcher

  • Rename the visible addon and data-broker launcher to Better Cooldown Manager.
  • Categorize the addon as Buffs & Debuffs.
  • Style the minimap tooltip with white instructions and green action text.

CI

  • Added a reusable Lua 5.1 test workflow for pushes and pull requests.
  • The workflow checks Lua version, parses every tracked Lua file, and runs Scripts/test.lua.
  • Release packaging now depends on the reusable quality workflow.

Commits

  1. feat: refresh settings window and package layout
  2. fix: support aura-only trackers and harden anchors
  3. docs: simplify in-game changelog
  4. fix: embed tracked bar settings in native options
  5. fix: reset trinket defaults and migrate anchors
  6. fix: update addon and minimap branding

Validation

  • lua5.1 Scripts/test.lua .
  • Lua 5.1 syntax checks with luac5.1 -p
  • bash -n install-deps.sh
  • git diff --check

Live WoW validation remains required for AuraContainer behavior, protected anchors, Edit Mode persistence, and combat/taint paths.

@silverbrit
silverbrit force-pushed the feat/12.1-audit-followups branch from fc76d7e to 849aedc Compare August 18, 2026 15:13
@silverbrit
silverbrit merged commit 44eb9fe into feature/12.1-modernization Aug 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant