fix: No UTF-8 validation happening when portable is disabled#445
Open
EmilyMatt wants to merge 8 commits into
Open
fix: No UTF-8 validation happening when portable is disabled#445EmilyMatt wants to merge 8 commits into
portable is disabled#445EmilyMatt wants to merge 8 commits into
Conversation
Licenser
force-pushed
the
fallback-utf8-validation
branch
from
b7d992c to
d67e714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When runtime-detection is enabled, but portable is not, we enter a code path that does NOT validate the UTF-8 input.
We then continue normally, reaching a codepath that claims that the UTF-8 was validated in the previous call(which it is, except not for the not(feature = "portable") code path
Added a fairly naive validation here, open to other suggestions.
Found by running miri on jsonchecker fail34
PR #442 from the same bunch will fix the CI issues, so this should be rebased and merged after