Skip to content

fix: panic when transport is not initialized #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EJTJ3 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: panic when transport is not initialized #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af636e9
fix: panic when transport is not initialized
EJTJ3 Nov 6, 2024
305f666
convert error message to lowercase
EJTJ3 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,6 +1184,10 @@ func (mc *ModbusClient) writeRegisters(addr uint16, values []byte) (err error) {
}

func (mc *ModbusClient) executeRequest(req *pdu) (res *pdu, err error) {
if mc.transport == nil {
err = ErrTransportNotInitialized
return
}
// send the request over the wire, wait for and decode the response
res, err = mc.transport.ExecuteRequest(req)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions modbus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ const (
ErrBadTransactionId Error = "bad transaction id"
ErrUnknownProtocolId Error = "unknown protocol identifier"
ErrUnexpectedParameters Error = "unexpected parameters"
ErrTransportNotInitialized Error = "transport is not initialized"
)

// mapExceptionCodeToError turns a modbus exception code into a higher level Error object.
Expand Down