Attaching the webhook-cert emptydir mount#331
Open
noctarius wants to merge 1 commit into
Open
Conversation
… writtable /tmp, cert creation will fail otherwise.
geoffrey1330
approved these changes
Jul 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm deployment manifest for simplyblock-operator to ensure the controller-runtime webhook serving certificate can be written at runtime even when the container is configured with readOnlyRootFilesystem: true (and /tmp is therefore not writable).
Changes:
- Add an
emptyDirvolume (webhook-certs) and mount it at/tmp/k8s-webhook-server/serving-certsso webhook cert generation can succeed on read-only root filesystems. - Restructure
volumeMounts:/volumes:blocks so the webhook cert mount is always present, while existing TLS-related mounts remain conditional.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+81
to
+83
| {{- if .Values.tls.enabled }} | ||
| {{- include "simplyblock.tlsVolumeMount" . | nindent 12 }} | ||
| {{- end }} | ||
| {{- end }} |
Comment on lines
+99
to
+101
| {{- if .Values.tls.enabled }} | ||
| {{- include "simplyblock.clientTlsVolume" (dict "ctx" . "clientSecret" "simplyblock-operator-client-tls") | nindent 8 }} | ||
| {{- end }} | ||
| {{- end }} |
boddumanohar
left a comment
boddumanohar
left a comment
Member
There was a problem hiding this comment.
I think the comments from copilot are meaningful and make sense to implement them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems without writtable /tmp, cert creation will fail otherwise.