fix(logs): close sidebar when selected log disappears from filtered list

[waleedlatif1]

Summary

• Bug fix: Sidebar now closes automatically when the selected log disappears from the filtered list (e.g., clearing an execution ID filter). Uses derived state (effectiveSidebarOpen) instead of a useEffect, avoiding extra render cycles and covering all filter-clearing paths.
• Cleanup: Removed 12 unnecessary useMemo and 6 useCallback calls from non-memo'd components in the logs module. Replaced a dashboard useEffect state reset with a render-time reset pattern. Fixed CSS variable token usage in the line chart. Added hierarchical statsAll key to the React Query key factory. Added partialize to the log details UI store to prevent persisting transient isResizing state.

Test plan

• Open logs page, select a log to open the sidebar
• Apply an execution ID filter, then clear it — sidebar should close
• Apply status/workflow filters, select a log, clear filters — sidebar should close if log is no longer in list
• Verify sidebar resize still works and persists width across reloads
• Verify dashboard chart segment selection resets when filters change
• Verify notification workflow selector still works

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 15, 2026 7:49pm

[cursor]

PR Summary

Medium Risk
Touches logs selection/sidebar visibility and dashboard segment-selection reset behavior; the new render-time reset logic and derived sidebar state could cause subtle UI regressions if conditions are miscomputed.

Overview
Fixes a logs UX bug by deriving effectiveSidebarOpen so the details sidebar automatically closes when the currently selected log is no longer present in the filtered/sorted list.

Refactors several logs-related components to remove unnecessary useMemo/useCallback usage and simplifies a few computed values, and changes the dashboard segment-selection reset from an effect to a key-based synchronous reset.

Also tweaks styling tokens in the dashboard LineChart, adds a hierarchical React Query key (logKeys.statsAll) for stats invalidation, and updates the persisted log-details UI store to only persist panelWidth (excluding transient isResizing).

^{Reviewed by Cursor Bugbot for commit f5d6b6f. Configure here.}

[greptile-apps]

Greptile Summary

This PR fixes a bug where the log details sidebar stayed open when the selected log was filtered out of the list. Instead of using a useEffect to dispatch a close action, it derives effectiveSidebarOpen as isSidebarOpen && selectedLogIndex !== -1, which is simpler and covers all filter-clearing paths in a single expression.

The cleanup work — removing useMemo/useCallback from non-memo'd components, converting the dashboard's useEffect segment-reset to a render-time state update, adding partialize to prevent isResizing from persisting, aligning CSS variable tokens in the line chart, and adding a statsAll() prefix key for targeted invalidation — is all mechanically correct.

Confidence Score: 5/5

Safe to merge — bug fix is correct, all cleanup changes are mechanically sound.

No P0 or P1 findings. The derived-state approach for effectiveSidebarOpen is the cleaner solution. The useCallback/useMemo removals are all in non-memo'd contexts (or inside memo'd components where the removed memos were never passed to child memo'd components). The render-time setState reset in dashboard.tsx follows the documented React pattern and avoids unnecessary resets on polling refreshes. The statsAll() key and partialize additions are straightforward improvements.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/logs/logs.tsx	Core bug fix via effectiveSidebarOpen derived state + mass removal of useMemo/useCallback from non-memo'd LogsFilterPanel; all logic is correct.
apps/sim/app/workspace/[workspaceId]/logs/components/dashboard/dashboard.tsx	Replaces useEffect with render-time setState reset; valid React pattern, correctly prevents re-renders when only stat values (not workflow IDs) change.
apps/sim/app/workspace/[workspaceId]/logs/components/logs-list/logs-list.tsx	Removes useCallback for DOM-only event handlers inside memo'd LogRow; safe because the custom comparator independently governs re-render decisions.
apps/sim/hooks/queries/logs.ts	Adds statsAll() prefix key and updates useCancelExecution to use it; hierarchical invalidation is now correct and targeted.
apps/sim/stores/logs/store.ts	Adds partialize to exclude transient isResizing from localStorage persistence; correct fix.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Filter changes] --> B{selectedLogIndex}
    B -- "-1 (log not in list)" --> C[effectiveSidebarOpen = false]
    B -- "≥ 0 (log in list)" --> D[effectiveSidebarOpen = isSidebarOpen]
    C --> E[LogDetails isOpen=false\nSidebar visually closes]
    D --> F{isSidebarOpen}
    F -- true --> G[LogDetails isOpen=true\nSidebar stays open]
    F -- false --> H[LogDetails isOpen=false\nSidebar stays closed]
    E --> I[isSidebarOpen store value\nunchanged — context preserved]
    I --> J{Filter cleared / log\nreappears in list}
    J -- selectedLogIndex ≥ 0 --> G

Loading

_{Reviews (1): Last reviewed commit: "fix(logs): close sidebar when selected l..." | Re-trigger Greptile}