Honor bounded LogStream backpressure for synchronous writes#45
Merged
CypherPotato merged 1 commit intoMay 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Channel<object>withFullMode=Waitwas introduced but synchronousLogStreamwrites usedTryWriteand threwInvalidOperationExceptionwhen the queue was full, which can propagate from request-finally logging and cause availability loss under log-flooding.Description
TryWritepath inLogStream.WriteLineInternal(string)with a synchronous wait onChannelWriter.WriteAsync(...).GetAwaiter().GetResult()so writes honor bounded-channel backpressure.ChannelClosedExceptionandOperationCanceledExceptionwhen cancellation is requested to preserve safe shutdown behavior consistent with the async writer.Testing
dotnet test tests/Sisk.Core/tests.csproj --filter LogStreamwhich restored and built projects successfully but the testhost failed to launch because the environment has only .NET 10 while tests target .NET 9, so tests could not be executed.tests/Sisk.Core/Sisk.Core.Tests.csproj) failed due to a missing project file and was retried with the correct path prior to the environment/runtime failure.Codex Task