fix: preserve legacy BeforeResponse handlers (ExecutionMode == 0)#46
Merged
CypherPotato merged 1 commit intoMay 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RequestHandlerExecutionModeto a[Flags]enum removed a zero-valued member and caused handlers with the default/legacyExecutionMode == 0to be silently skipped, which can bypass pre-route handlers such as authentication.Description
ExecutionMode == 0as a legacyBeforeResponsehandler during dispatch by updating theInvokeRequestHandlerGroupconditional to also acceptrh.ExecutionMode == 0 && mode == RequestHandlerExecutionMode.BeforeResponse, while preserving the existingHasFlagbehavior for current flag values.Testing
dotnet test tests/Sisk.Core/tests.csproj; restore and compilation succeeded but the test run aborted because the execution environment lacks the required .NET 9 runtime (only .NET 10 is installed), so no unit test results were produced.Codex Task