Note the lefthook pre-push manual-run caveat (needs --all-files)#238
Open
sksizer wants to merge 3 commits into
Open
Note the lefthook pre-push manual-run caveat (needs --all-files)#238sksizer wants to merge 3 commits into
sksizer wants to merge 3 commits into
Conversation
A manual `bunx lefthook run pre-push` skips its gates ("no matching push
files") on a branch with no upstream / no unpushed commits, so exercising the
gate by hand needs `--all-files` (or a real `git push`).
…ok-prepush-run-caveat
sksizer
added a commit
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lefthook.yml: adds a "Manual run caveat" note to thepre-push:comment block —bunx lefthook run pre-pushreports "no matching push files" and skips its gates on a branch with no upstream / no unpushed commits, so a by-hand check needs--all-files(or a realgit push).README.md: appends an equivalent, consistently-worded caveat sentence to the Git hooks bullet. Comment/docs-only — no hookrun:command or gate behavior changes.Task
docs/planning/tasks/T-TH8U-document-lefthook-prepush-run-caveat.md
Acceptance criteria
lefthook.ymlnotes thatbunx lefthook run pre-pushskips its gates on a branch with no unpushed commits and that--all-files(or a realgit push) is required by hand. (auto — verified ingit diff origin/main -- lefthook.yml)git diff origin/main -- README.md)run:command or gate behavior changes — diff limited to a comment inlefthook.ymland prose inREADME.md. (auto — two-dot diff is+12/-1,run:line unchanged; baseline-gatedsdlc quality runreportedOK 6/6, no new drift)Test plan
Follow-up tasks spawned
No new tasks spawned. One friction bullet (Step 7
quality run --diff-against-baselineresolving--baseline-dirto the worktree instead of the superproject) was linked to the existing upstream taskT-F1WJ-quality-run-resolves-superproject-baseline(sksizer/dev) rather than duplicated.