feat(scaffold): post-mount stem for plinth-hosted readouts (#286) - #287
Closed
bradleypmartin wants to merge 1 commit into
Closed
feat(scaffold): post-mount stem for plinth-hosted readouts (#286)#287bradleypmartin wants to merge 1 commit into
bradleypmartin wants to merge 1 commit into
Conversation
Adds a ReadoutPost cylinder primitive in a sibling 'surface'-oriented plinth slot per readout, killing the "floating monitor" read from #285 smoke. Two-slot architecture: post anchored statically to the working surface; readout slot lifted by READOUT_POST_LENGTH along the surface normal. PanelReadout.faceCamera unchanged — today's world-Y yaw preserved across all four cluster scenes.
|
Preview deploy ready — commit https://geometer-pr-287.1bradley-martin1.workers.dev Open this URL in the Quest browser to smoke-test in headset. |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286 once headset smoke confirms the post reads as plinth hardware.
Summary
ReadoutPostprimitive (src/scaffold/ui/ReadoutPost.ts) registered in its own'surface'-oriented plinth slot at the same XY as each readout. Post is statically anchored to the working surface (nofaceCameraoverwrite); the readout slot'slocalXYZ[2]lifts the readout group byREADOUT_POST_LENGTHalong the surface normal so the readout group origin sits at the post tip.PanelReadout.faceCamerais unchanged — today's world-Y yaw billboard is preserved across all four cluster scenes. No changes to back-plate, text layout, dimensions, or rotation math._private/plans/286-readout-post-mount.mdv3 (post-roundtable + second-Sonnet sanity pass).Architecture context
v1 of the plan proposed yawing the panel around the post axis. Three-vendor
/roundtable-plan-reviewreturned overall HOLD — four convergent HIGH findings on broken rotation math. v2 abandoned that design in favor of two slots per readout (post + panel as separate plinth-registered primitives, panel preserves today's billboard). v2 → second-Sonnet PROCEED with two LOW tightening nits, folded into v3 (explicitorientation: 'surface'at the post slot sites, plus a wiring test asserting the post quaternion equalsR_x(-PLINTH_TILT_DEFAULT)aftercreatePlinthplacement).The post is purely visual signaling that the readout is mounted on the plinth — not a kinematic element. Panel center orbits the lifted slot point on an 8 mm radius circle as yaw varies (panel-back is 8 mm behind group origin in local Z); at panel scale (half-widths 0.20–0.38 m) this is visually invisible.
Test plan
npx vitest run— 46 files, 610 tests passing (6 new tests intest/scaffold/ui/ReadoutPost.test.ts).npx tsc --noEmit— clean.pre-commit— gitleaks + eslint + standard fixers clean.PLINTH_*_READOUT_Yper-scene in this PR before merge).Refs: #286 (this), #285 (smoke source), #270 (closed; chrome family), #225 (parent sub-epic), #221 (v1.0 staging epic), #271 (composition partner).