Give the skill tree window room for the client area the skin really has - #5
Merged
slapin merged 1 commit intoAug 24, 2026
Conversation
The F4 skill tree laid its three columns and button bar out for a 610x392 window whose client area was the whole window, which is what the broken ClientWithTitleWithFrame area in the old skin gave it. With the skin's client area fixed to sit inside the frame and below the titlebar, the same window only has 538x329 to offer, and the content no longer fits: the magic column loses its right half and the fourth row of skills is cut through the middle, with nothing to scroll by. The content needs 610x380; with 36px of frame a side and a 27px titlebar that means a 690x450 window, which still fits the 800x600 design minimum. Same class of fix as the Yes/No dialogs that needed height for the titlebar the skin actually draws. Verified in a single-player game at 1920x1200: all three skill columns show every row, and the Auto Fill / Unselect All / Cancel / Apply bar sits clear below them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014hrk8PiEUMgjYJnTxLF2PU
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken F4 skill tree tomluchowski reported on tomluchowski#15 (comment 5345307447).
The layout sizes the window 610x392 and lays its three skill columns + button bar out for a client area that big — which is what the old skin's broken
ClientWithTitleWithFrame(empty area = whole window) used to give it. With the skin's client area fixed to sit inside the frame and below the titlebar (the PR #2 titlebar work), the same window only offers 538x329, so the magic column loses its right half and the fourth skill row is cut through the middle, with no scrollbar to reach the rest. Same class of fix as the Yes/No dialogs that needed height for the titlebar the skin actually draws — measured at runtime: frame is 36px a side plus a 27px titlebar, content needs 610x380, so the window becomes 690x450 (still fits the 800x600 design minimum).Verified in a single-player game at 1920x1200 against Ogre 14.6 + the CEGUI fork with #2 merged: all three columns show every skill, progress bars and green ticks included, and Auto Fill / Unselect All / Cancel / Apply sit clear below.
🤖 Generated with Claude Code
https://claude.ai/code/session_014hrk8PiEUMgjYJnTxLF2PU