FIX: Small code-review fixes + FAQ section - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Ticket(s)
N/A
Link(s)
N/A
Example(s)
Dependencies
None.
Design
copyAll:Statusno longer exposes a general-purpose copy method. Its one realdependent,
Status.ofStatus, still works the same way internally, just without a public mutationescape hatch.
isNeutral: a computed convenience that read as contradictory in practice(
Excludedbeing bothsuccess = trueand "neutral" at once).is Passed.Excluded || is Passed.Informationis still trivially available inline.Rejected's HTTP default: 500 → 409: a well-formed, understood request that'srefused on a business rule is a client-side outcome, not a server fault.
Statusis a data class, so the oldMap<Status, Int>overrides compared every field, including the message. Two statuses with thesame identity but a slightly different message could silently miss their override. Rekeyed to
match on
origin+nameinstead.UNSUPPORTED→12: previously flagged as an inference; now confirmed anddocumented as such.
(Arrow, kotlin-result), taxonomy details, adoption guidance, and maturity/trust questions.
Notes
None.
Pending
None.
Tests
codes tie at 409 vs 500.
CompositeLookupmatch by identity evenwhen the message differs.
copyAll/isNeutraldirectly.ktlintCheck+detekt+jvmTest+jsNodeTestrun clean.