FEAT: Add groupDescription, sync Unserved with 3 new codes - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
groupDescriptionfield: a runtime-readable explanation for each status category.groupDescriptioninstead of restating it.DEGRADED,LEGAL_BLOCK,ABORTEDadded toUnserved, closing a gRPC gap.Ticket(s)
N/A
Link(s)
N/A
Example(s)
Dependencies
None.
Design
groupDescription: added toPassedandFailed, same patterngroupalready uses —makes each category's meaning a real runtime value instead of only living in a KDoc comment.
groupDescription. Kept the genuinely usefulextra detail on
Excluded(theSKIPPED/DISCARDEDnaming note) andUnserved(the examplelist), rather than deleting everything uniformly.
DEGRADED: a dependency is degraded, some calls may be refused.LEGAL_BLOCK: access restricted for legal/regulatory reasons. Maps to HTTP451.ABORTED: operation aborted before completing, retrying may succeed. Maps directly togRPC's own
ABORTED(10) — gRPC now has full 0-16 coverage, no more gaps.Notes
Excluded.CANCELLED's message wording andLEGAL_BLOCK's category placement alone —both still open questions, not settled enough to bundle into this change.
Pending
None.
Tests
groupDescription(non-blank, distinct per category, consistent per subtype).category-default fallthrough for
DEGRADED/LEGAL_BLOCKon gRPC.ABORTEDmaps to null" test with one confirming the real mapping.ktlintCheck+detekt+jvmTest+jsNodeTestrun clean.