CMAC2_COUNTER and four more antidumping macros run unmodified on Jenner - #4
Open
jenner-analytics wants to merge 1 commit into
Open
Conversation
Adds jenner-check/, five self-contained bundles exercising macros from common-macros.sas, me-macros.sas, and nme-margin-calculation.sas against mock antidumping sales data (CMAC2_COUNTER, DEFINE_SALE_DATE, UNIQUE_CONNUMS, CREATE_QUARTERS, CONVERT_TO_USD), plus the run_jenner.sh runner and its README. Nothing outside jenner-check/ is touched and nothing runs on merge or checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenneranalytics.com provides an API that runs SAS code, with support for more than 200 SAS procedures. You can also use it with AI assistants in a collaborative workspace. It's available for Mac on the Apple App Store, and by license for Windows and Linux.
We support the larger community by
(1) increasing access to SAS-compatible systems,
(2) by providing test coverage and a test coverage framework to public SAS repos in order to encourage the use of best practices in software engineering.
Your common-macros.sas runs on Jenner unmodified — this PR adds a small compatibility bundle so you can see for yourself. It's the test we wrote for your antidumping package, shared in case it's useful, and was assembled with AI assistance as is most code in modern businesses today.
Ten years of tracking Commerce's own antidumping calculation programs is a genuinely useful thing to have kept in sync — the commit history shows real care, like the 2022 change that deliberately dropped the detailed program listing from the README specifically to avoid it drifting out of sync with trade.gov (as happened once already with a home-market file rename). CMAC2_COUNTER, tucked into common-macros.sas, is a good example of the kind of small, sturdy utility that makes the rest of the pipeline auditable: a two-line PROC SQL wrapper that turns any dataset into a named macro variable count, called at every stage of the margin calculation so the log always shows how many observations survived each filter.
jenner-check/contains five bundles, each pairing a macro from this repo with a small caller built from a realistic mock sales dataset:Check out this PR's branch and run from the repo root, then any bundle is one curl call away:
cd jenner-check && ./run_jenner.sh --allre-runs all five and checks each result against the pinned log/output snapshot captured when the bundle was built. The hosted API is free to try, no signup required; full reference at the docs.Only the SAS source text of whatever script you run —
autoexec.sasplusscript.sas, nothing else — is sent to api.jenneranalytics.com, which runs it and returns the log and listing. No data files are read or uploaded, so anything sitting next to a script (or the COMPANY library paths these programs expect) stays on your machine; nothing is transmitted unless you run a command yourself.Merge it, close it, or ignore it — no response expected either way, and we won't open further PRs on this repo. To opt out for good, leave
no-more-prsin a comment here or open an issue titledjenner-check: opt out.Lawrence W. Sinclair
CEO / Jenner Analytics Ltd
linkedin.com/in/lwsinclair/