chore: implement phase 6 - #2784
Draft
Tofel wants to merge 2 commits into
Draft
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p6
branch
from
September 1, 2026 11:25
c1f0275 to
a68bc90
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p6
branch
from
September 1, 2026 14:18
a68bc90 to
2bbb84b
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p6
branch
from
September 1, 2026 14:46
2bbb84b to
4161182
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p6
branch
from
September 1, 2026 15:25
4161182 to
2b64acf
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p6
branch
2 times, most recently
from
September 4, 2026 15:03
07d2fb9 to
c7a6144
Compare
Invariant defended: H2. The one question: can watch return success over a window that nothing is recording? Watch() records the first observation of each non-skipped rule, then detaches a child that polls at the cadence in the header. The parent returns only after the child reports ready on an inherited pipe, and writes the pidfile after that. A clean stop writes the sentinel; a hard error does not.
Tofel
force-pushed
the
dx-5122-alerts-assertion-p6
branch
from
September 4, 2026 15:15
c7a6144 to
eabba1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
Watch()(invariant H2): record the first observation of each non-skipped rule, detach a child that polls, return after the child reports ready on an inherited pipe, write the pidfile only then; a clean stop writes the sentinel, a hard error does not.Review focus:
watch.goparent/child handshake and the pidfile-vs-sentinel semantics.