chore: use testify's require in tests - #2792
Draft
Tofel wants to merge 1 commit into
Draft
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p13
branch
from
September 4, 2026 15:03
c97e92d to
10c74ca
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p13
branch
from
September 4, 2026 15:15
10c74ca to
33eea1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all test assertions from hand-rolled
t.Fatal/Errorto testifyrequire, adds thetestifydependency, and adds a recorder-mode fail-fast incheck.goforfrom < StartedAt.Review focus: the
check.gofail-fast (the only non-test change); the rest is a mechanical assertion swap.