chore: remove bitnami helm repo registration (IP-3481) - #2804
Open
tvc-jeffwelling wants to merge 2 commits into
Open
chore: remove bitnami helm repo registration (IP-3481)#2804tvc-jeffwelling wants to merge 2 commits into
tvc-jeffwelling wants to merge 2 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The Bitnami repo registration is removed cleanly without leaving any remaining in-repo references to the Bitnami repo URL or bitnami repo name.
Pull request overview
Removes the Bitnami Helm repository registration from the k8s Docker build images and from an unused Helm repositories config file, ensuring CTF no longer configures the public Bitnami repo by default.
Changes:
- Dropped
helm repo add bitnami https://charts.bitnami.com/bitnamifrom the base k8s Docker image build steps. - Dropped the same Bitnami repo registration from the
lib/k8s/examples/linkDockerfile. - Removed the
bitnamientry from.helm-repositories.yaml.
File summaries
| File | Description |
|---|---|
lib/k8s/examples/link/Dockerfile |
Removes Bitnami Helm repo registration during image build. |
lib/k8s/Dockerfile.base |
Removes Bitnami Helm repo registration during image build. |
.helm-repositories.yaml |
Removes the bitnami repository entry from the repo list. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chainchad
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Removes the three Bitnami Helm repo registrations from CTF (IP-3481):
lib/k8s/Dockerfile.base- drophelm repo add bitnami https://charts.bitnami.com/bitnamilib/k8s/examples/link/Dockerfile- same line.helm-repositories.yaml- remove thebitnamientry (file is an orphan from the removed nix shell feature, TT-1042; nothing references it)No chart pulls by repo name
bitnamiexist anywhere in the repo - these are pure registrations. Kafka/influx charts come viaBITNAMI_PRIVATE_REGISTRY(separate scan rows, separate PR).Why this commit uses
--no-verify: the repo's pre-commit hookset is broken on main for everyone:go-lintfails:just lint-allcallsjust lint havoc(justfile:25) but no top-levelhavoc/dir exists on main.go-mod-tidyfails on any dirty tree, andgo-lint'sgolangci-lint --fix(justfile:17) mutates files, which then fails the tidy diff - the two hooks contradict each other.typosfails on ~35 pre-existing typos across the repo (none in the files changed here; a few are false positives in vendored code, one is inside a private-key literal).None of the skipped checks involve files in this change. Verified via probe PR #2803 (empty commit): CI runs
just lintper module + full test matrix + workflow checks - all green. CI does not run pre-commit.