TokenAdminRegistry - #857
Draft
vicentevieytes wants to merge 9 commits into
Draft
Conversation
vicentevieytes
force-pushed
the
vv/TokenAdminRegistry
branch
from
August 26, 2026 15:34
61c90bd to
39f16f8
Compare
vicentevieytes
commented
Sep 2, 2026
| // crc32('CCIPSendExecutor_Execute') | ||
| struct (0xaf3c62b3) CCIPSendExecutor_Execute { | ||
| onrampSend: OnRamp_Send, | ||
| // Derived by the OnRamp rather than supplied by the Router. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| // Derived by the OnRamp rather than supplied by the Router. |
vicentevieytes
commented
Sep 2, 2026
| struct OffRamp_Deployables { | ||
| rmnRouter: address; | ||
| // Separate TokenAdminRegistry root used to derive deterministic entries. | ||
| tokenAdminRegistry: address; |
Collaborator
Author
There was a problem hiding this comment.
Probably doesn't make sense to have this both here and in Config
vicentevieytes
commented
Sep 2, 2026
Comment on lines
+272
to
+273
| // The Router deliberately does not supply this address. The OnRamp | ||
| // derives the entry from its configured standalone registry root. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| // The Router deliberately does not supply this address. The OnRamp | |
| // derives the entry from its configured standalone registry root. |
duck-types
reviewed
Sep 4, 2026
| struct (0xaf3c62b3) CCIPSendExecutor_Execute { | ||
| onrampSend: OnRamp_Send, | ||
| // Derived by the OnRamp rather than supplied by the Router. | ||
| tokenRegistry: address?, |
Collaborator
There was a problem hiding this comment.
I'd put it in Config together with all the other addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.