Skip to content

Use shared Renovate preset from smkwlab/.github - #30

Merged
toshi0806 merged 1 commit into
mainfrom
use-shared-renovate-preset
Jun 3, 2026
Merged

Use shared Renovate preset from smkwlab/.github#30
toshi0806 merged 1 commit into
mainfrom
use-shared-renovate-preset

Conversation

@toshi0806

Copy link
Copy Markdown
Member

Summary

Replace the duplicated Renovate configuration with a one-line extends of the org-wide shared Elixir preset, pinned to the v1 tag.

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["github>smkwlab/.github:elixir#v1"]
}

The mix-manager config, lockFileMaintenance, grouping (elixir dependencies), and grouped minor/patch/digest auto-merge are now defined centrally in smkwlab/.github (elixir.json @ v1), so behavior is preserved.

Context

Part of the ecosystem-wide Renovate consolidation. Shared presets added/pinned in smkwlab/.github#28 and #29 (merged, released as v1.6.0). The Elixir preset intentionally retains minor/lockFileMaintenance auto-merge as a documented exception to the org's patch/digest-only default.

Replace the duplicated Renovate configuration with a one-line extends of
the org-wide shared Elixir preset pinned to the v1 tag. The mix manager
config, lockFileMaintenance, grouping and auto-merge behavior are now
defined centrally in smkwlab/.github (elixir.json @ v1); behavior is
preserved.

Part of the ecosystem-wide Renovate consolidation (smkwlab/.github#28, #29).
Copilot AI review requested due to automatic review settings June 3, 2026 11:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates Renovate configuration by replacing the repository-local, duplicated settings with an extends reference to the org-wide shared Elixir preset in smkwlab/.github pinned to #v1.

Changes:

  • Replace the full local Renovate configuration with a single shared preset reference (github>smkwlab/.github:elixir#v1).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread renovate.json
Comment on lines 1 to 4
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["config:recommended"],
"enabledManagers": ["mix"],
"schedule": ["before 6am on monday"],
"timezone": "Asia/Tokyo",
"lockFileMaintenance": {
"enabled": true,
"schedule": ["before 6am on monday"]
},
"packageRules": [
{
"matchManagers": ["mix"],
"matchDatasources": ["hex"],
"matchUpdateTypes": ["minor", "patch", "digest", "lockFileMaintenance"],
"groupName": "elixir dependencies",
"automerge": true,
"platformAutomerge": true
}
]
"extends": ["github>smkwlab/.github:elixir#v1"]
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご指摘ありがとうございます。正確です — dependencyDashboardsemanticCommits: enabled は共有土台 default.json 由来で新たに有効になります。

これは意図的な org標準化です。latex-ecosystem 側のリポジトリは既にこれらを使用しており、Elixir 系も共有プリセットの採用に合わせて同じ org標準(依存ダッシュボード+セマンティックコミット)に揃える方針です。

「behavior preserved」が指していたのは依存更新の実質挙動(mix のグループ化・スケジュール・lockFileMaintenance・minor/patch/digest の自動マージ)で、これらは維持されます。コミットメッセージ形式とダッシュボードは org標準へ統一、という位置づけです。PR説明の表現はこの趣旨に合わせて補足します。

@toshi0806

Copy link
Copy Markdown
Member Author

レビュー対応 (Copilot指摘)

共有プリセット :elixir#v1 が org default 由来で dependencyDashboard / semanticCommits を有効化する、というご指摘について:

結論: 意図的な org標準化として採用します。

  • これらは共有土台 default.json が定義する org共通設定で、latex-ecosystem 側は既に採用済み
  • Elixir 系も共有プリセット採用に合わせ、依存ダッシュボード+セマンティックコミットを org標準に統一
  • 依存更新の実質挙動(mix グループ化・スケジュール・lockFileMaintenance・minor/patch/digest 自動マージ)は維持

この方針は本PRを含む Elixir 系5repo 共通です。なお PR説明の「behavior preserved」は依存更新挙動を指す旨を上記で補足しました。

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread renovate.json
"platformAutomerge": true
}
]
"extends": ["github>smkwlab/.github:elixir#v1"]
@toshi0806
toshi0806 merged commit 72c42ca into main Jun 3, 2026
6 checks passed
@toshi0806
toshi0806 deleted the use-shared-renovate-preset branch June 3, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants